-
Notifications
You must be signed in to change notification settings - Fork 82
Refactor linear algebra to use "tuples" for what was "vectors" #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using the terminology "finite sequence" (finite-sequence
) for functions Fin n -> A
. This is consistent with our use of the term "sequence", and leaves the confusing term "functional" available to only be used for linear functionals.
Thank you for taking this on, by the way! Sorry if my appreciation is not sufficiently communicated through my other comments. |
Also, to verify, you are not making any other changes in this PR aside from renaming the concepts, the appropriate files, and fixing the appropriate prose to reflect this renaming, correct? |
That's correct. |
That might no longer be correct. While splitting out files for tuples and finite sequences, I might fill out parts that got left out for one or the other. |
no worries! |
How would we feel, by the way, about moving the definition of tuples and finite sequences from |
src/linear-algebra/finite-sequences-on-commutative-rings.lagda.md
Outdated
Show resolved
Hide resolved
src/linear-algebra/finite-sequences-on-commutative-rings.lagda.md
Outdated
Show resolved
Hide resolved
src/linear-algebra/finite-sequences-on-commutative-semirings.lagda.md
Outdated
Show resolved
Hide resolved
src/linear-algebra/finite-sequences-on-euclidean-domains.lagda.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Fredrik Bakke <[email protected]>
src/linear-algebra/finite-sequences-in-commutative-rings.lagda.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much again for implementing these terminological fixes. They turned out to be a lot more involved than I had anticipated, but I'm very glad you implemented them!
Does this PR completely resolve #1389, or are there further changes you want to implement, such as regarding "componentwise"? |
Addresses #1389 .