Skip to content

Refactor linear algebra to use "tuples" for what was "vectors" #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
May 14, 2025

Conversation

lowasser
Copy link
Collaborator

@lowasser lowasser commented Apr 6, 2025

Addresses #1389 .

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using the terminology "finite sequence" (finite-sequence) for functions Fin n -> A. This is consistent with our use of the term "sequence", and leaves the confusing term "functional" available to only be used for linear functionals.

@fredrik-bakke
Copy link
Collaborator

Thank you for taking this on, by the way! Sorry if my appreciation is not sufficiently communicated through my other comments.

@fredrik-bakke
Copy link
Collaborator

Also, to verify, you are not making any other changes in this PR aside from renaming the concepts, the appropriate files, and fixing the appropriate prose to reflect this renaming, correct?

@lowasser
Copy link
Collaborator Author

That's correct.

@lowasser
Copy link
Collaborator Author

That might no longer be correct. While splitting out files for tuples and finite sequences, I might fill out parts that got left out for one or the other.

@fredrik-bakke
Copy link
Collaborator

no worries!

@lowasser
Copy link
Collaborator Author

How would we feel, by the way, about moving the definition of tuples and finite sequences from linear-algebra to lists? It feels more accurate to me.

lowasser and others added 2 commits May 6, 2025 18:17
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much again for implementing these terminological fixes. They turned out to be a lot more involved than I had anticipated, but I'm very glad you implemented them!

@fredrik-bakke
Copy link
Collaborator

Does this PR completely resolve #1389, or are there further changes you want to implement, such as regarding "componentwise"?

@fredrik-bakke fredrik-bakke linked an issue May 14, 2025 that may be closed by this pull request
@fredrik-bakke fredrik-bakke enabled auto-merge (squash) May 14, 2025 09:27
@fredrik-bakke fredrik-bakke merged commit 23f1480 into UniMath:master May 14, 2025
4 checks passed
@lowasser lowasser deleted the linear-refactor branch May 14, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linear algebra terminology overhaul
2 participants