Skip to content

#1375 Units for false_easting and false_northing (fix) #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adriaanse-deltares
Copy link

@adriaanse-deltares adriaanse-deltares commented Jun 27, 2025

Description of Changes

See the description of the issue #1375

I have worked with GIS systems and Geographic projections at Deltares since 1998 and I am 100% sure that:
No exceptions exist where false easting/northing units differ from the projected coordinates. These values are intrinsic to the coordinate system's design and always share the same units

So I propose to remove the scaling of these parameters completely, also for other projections where it is applied.

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2025

CLA assistant check
All committers have signed the CLA.

@lesserwhirls
Copy link
Member

I appreciate you taking the time to make this PR, and it certainly gave me some hints when trying to untangle what was happening. As I said over in #1375, we probably need to support the scaling in the read path. However, I was able to get the scaling addressed in the write path when writing from a Coverage, which will fix the issue of the NetCDF Subset Service producing netCDF files with mismatched cartesian coordinate units and false_easting/false_northing values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants