Issue resolution: :g[lobal] feature not present #9556 #9557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akshansh20018
changed the title
|
Mind writing a few tests? |
Sure, will update the PR in a couple days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements the missing :g[lobal] feature. Takes the input format as:
:g/{regex}/{command}Currently only works for
dcommand i.e., todeleteWhich issue(s) this PR fixes
Resolves issue
:g[lobal] feature not present #9556Special notes for your reviewer:
This is my first time contributing, do let me know if it does not adhere to the pattern or style.