Skip to content

Switch blank video from smpte to a missing-codecs message #8659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: proton_10.0
Choose a base branch
from

Conversation

nirbheek
Copy link

@nirbheek nirbheek commented May 5, 2025

/r/linux_gaming and other forums regularly get posts asking about "weird colors" in games with cutscenes:

https://www.reddit.com/r/linux_gaming/comments/1kf59i6/fragpunk_showing_weird_colors/

https://www.reddit.com/r/linux_gaming/comments/1k47643/blue_prince_game_launches_but_when_i_click_new/

https://www.reddit.com/r/linux_gaming/comments/1ftevcl/star_wars_jedi_survivor_is_giving_me_a_weird/

Putting a message in there is probably more useful.

Also switch audio to use wave=silence, which is more correct.

This is what the video will look like after this change:
image. As a bonus, the video will also be smaller.

@nirbheek
Copy link
Author

nirbheek commented May 5, 2025

Note that this change requires the textoverlay element which is part of the pango plugin. Since this MKV is generated at build-time this doesn't change the runtime requirements of Proton, but it does require that the gstreamer that you use on your build machines ship that pango gstreamer plugin. I noticed that this build-env gstreamer is already different from the gstreamer you ship with Proton since it ships with an av1 encoder, and Proton does not.

Note that the pango plugin is shipped by default on all Linux distros, so it should be easy to gain access to.

/r/linux_gaming and other forums regularly get posts asking about
"weird colors" in games with cutscenes:

https://www.reddit.com/r/linux_gaming/comments/1kf59i6/fragpunk_showing_weird_colors/
https://www.reddit.com/r/linux_gaming/comments/1k47643/blue_prince_game_launches_but_when_i_click_new/
https://www.reddit.com/r/linux_gaming/comments/1ftevcl/star_wars_jedi_survivor_is_giving_me_a_weird/

Putting a message in there is useful. Other changes done:

* Switch audio to use wave=silence, which is more correct.
* Add a horizontals-speed to have the video move to the left
* Increase buffers from 120 to 160 to loop perfectly
@nirbheek
Copy link
Author

Could you overlay it on the test pattern? That may be the best of both worlds.

Done. I also made the pattern move and made it loop perfectly. I figured that you might've wanted movement to clarify that the game is not frozen. The change was:

- num-buffers=120 pattern=black
+ num-buffers=160 horizontal-speed=2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant