cmake: binaryninjaui depends on binaryninjaapi #6822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes building the uinotification example that only links against
`binaryninjaui`.
Without this fix, there's a compilation error about not finding
`binaryninjaapi.h`:
```
In file included from binaryninja-api/examples/uinotification/uinotification.cpp:2:
In file included from binaryninja-api/examples/uinotification/uinotification.h:3:
binaryninja-api/ui/uicontext.h:8:10: fatal error: 'binaryninjaapi.h' file not found
8 | #include "binaryninjaapi.h"
| ^~~~~~~~~~~~~~~~~~
1 error generated.
```
|
The |
|
This was cherry-picked into my C++20 branch as c19bcd7, which was merged yesterday. Sorry for the wait, but thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes building the uinotification example that only links against
binaryninjaui.Without this fix, there's a compilation error about not finding
binaryninjaapi.h: