Type allocations as exact #7589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update RefFunc, StructNew, ArrayNew*, ContNew, and ContBind expression to have exact reference types, as they will under the custom descriptors proposal. Even without that proposal enabled, using exact types in the IR can help better optimize casts and generally allows us to propagate more precise type information. Update the fuzzer to avoid assertion failures and invalid output now that it can observe exact types via allocations. Update test output to contain newly emitted exact types.
tlively
commented
May 14, 2025
Comment on lines
+424
to
+425
| # Add --fuzzing to allow legacy and standard EH to coexist | ||
| cmd = [shared.V8, '--wasm-staging', '--fuzzing', fuzz_file] |
There was a problem hiding this comment.
This is probably an unrelated side effect of having updated my local V8 version.
kripken
reviewed
May 15, 2025
| (struct.new_default $"{i32}") | ||
| (struct.new_default $"{i32_i64}") | ||
| (i32.const 0) | ||
| ) |
There was a problem hiding this comment.
perhaps add a comment here? i can't figure out why it was needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RefFunc, StructNew, ArrayNew*, ContNew, and ContBind expression
to have exact reference types, as they will under the custom descriptors
proposal. Even without that proposal enabled, using exact types in the
IR can help better optimize casts and generally allows us to propagate
more precise type information.
Update the fuzzer to avoid assertion failures and invalid output now
that it can observe exact types via allocations. Update test output to
contain newly emitted exact types.