Fix tests of refinalization after optimization of selects #7595
+95
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSI previously only optimized globals whose types were the same as their initializer's types to ensure the glboal types were equality comparable. However, this is an overly conservative restriction because the global can have any type up to eqref without causing problems. Update the restriction to be more precise. This will help the GSI tests continue working once `struct.new` is typed as exact.
According to their comments, these tests purported to show that refinalize was run after optimizing a select to a single arm with a more refined type. However, the tests were flawed because the select arms had the same type, meaning the parsed select node did not have a less refined type than the arms. Fix this by giving the arms different types. Use a block to directly show that refinalization occurred instead of the cast that was there previously.
tlively
force-pushed
the
fix-opt-inst-select-test
branch
from
16407f3 to
ac5354e
Compare
kripken
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to their comments, these tests purported to show that refinalize was
run after optimizing a select to a single arm with a more refined type. However,
the tests were flawed because the select arms had the same type, meaning the
parsed select node did not have a less refined type than the arms. Fix this by
giving the arms different types. Use a block to directly show that
refinalization occurred instead of the cast that was there previously.