Fix missing Exact type ReFinalization in TypeMerging #7619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
May 22, 2025
src/passes/TypeMerging.cpp
Outdated
| // (A) ;; now A | ||
| // ) | ||
| // | ||
| ReFinalize().run(getPassRunner(), module); |
There was a problem hiding this comment.
We could still check whether any merging occurred before refinalizing.
| if (refinalize) { | ||
| ReFinalize().run(getPassRunner(), module); | ||
| } | ||
| // If we merge siblings, we also need to refinalize because the LUB of merged |
There was a problem hiding this comment.
Let's add a comment about why merging parents can require refinalization as well. (That will make the "also" make more sense here, too.)
There was a problem hiding this comment.
Sorry, I don't follow. The existing comment explained refinalization after merge(Siblings), and the new comment, for merge(Supertypes). Are those not the two cases? I'm not sure what else is unexplained.
tlively
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we merge siblings to their parent, they may end up equal:
In such cases we must refinalize, as the LUB is now exact.