Ai multi endpoint classifier #1265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcuri82
requested changes
Jun 27, 2025
| class AIResponseClassifier( | ||
| private val config: EMConfig = EMConfig(), | ||
| private val explicitModel: AIModel? = null | ||
| ) : AIModel { |
There was a problem hiding this comment.
the injection here shouldn't be touched. constructor should have no inputs. long story...
recall this class is instantiated as singleton with a DI framework
arcuri82
requested changes
Jun 30, 2025
|
|
||
| private lateinit var delegate: AIModel | ||
| private lateinit var model: AIModel |
There was a problem hiding this comment.
why changing the name from delegate to model? AIResponseClassifier itself extends AIModel, but delegates its execution to another model.
| } | ||
|
|
||
| fun getInnerModel(): AIModel = model |
There was a problem hiding this comment.
returning a mutable state reference is usually not a good idea in OO, as it can lead break incapsulation. at times, we need it. in those cases, to make it explicit, i prefer to use the term view instead of get, eg, viewInnerModel
There was a problem hiding this comment.
Tnx, I'll fix it
arcuri82
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIGaussianCheck.kt and AIGlmCheck.kt are updated to show how we can deal with an api with mutiple endpoints