Warning about using std::counting_semaphore

[vlntb]

High Level Overview of Change

Comment added.

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[lmaisons]

Is it worth sticking a pragma message in there for GCC and Clang versions higher than our targets?

[vlntb]

Is it worth sticking a pragma message in there for GCC and Clang versions higher than our targets?

We discussed this and decided that it is not worth it. Most of the deployments today will not be able to take advantage of this optimisation.

[lmaisons]

That's fair. I have experience with features waiting on 'eventual' compiler support (7 8 years and counting?), so may be untowardly prone to defensiveness in the area...

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.8%. Comparing base (baf4b83) to head (76c5943).

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5595     +/-   ##
=========================================
- Coverage     78.8%   78.8%   -0.0%     
=========================================
  Files          814     814             
  Lines        71261   71262      +1     
  Branches      8368    8369      +1     
=========================================
  Hits         56131   56131             
- Misses       15130   15131      +1     

Files with missing lines	Coverage Δ
src/xrpld/core/detail/semaphore.h	100.0% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Bronek]

I don't think that's fixed in gcc 13.3 , given that its release date is May 2024 and the bug was fixed in June 2025 in https://gcc.gnu.org/cgit/gcc/commit/?id=7be4913b8f8b1e1474751656d45b301aa0c20790 . It might have been fixed in gcc 13.4 (released in June 2025) but we would have to verify that.

[vlntb]

You are correct. Checked and updated.