Skip to content

fix(sandbox):when script run with error,the sandbox will not be destroyed #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(sandbox):when script run with error,the sandbox will not be destroyed #2671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions server/utils/sandbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
const Safeify = require('safeify').default;

module.exports = async function sandboxFn(context, script) {
let result
// 创建 safeify 实例
const safeVm = new Safeify({
timeout: 3000,
asyncTimeout: 60000
})

script += "; return this;";
// 执行动态代码
const result = await safeVm.run(script, context)

try {
// 执行动态代码
result = await safeVm.run(script, context)
} catch (error) {
console.log('error: ', error)
}

// 释放资源
safeVm.destroy()
Expand Down