add show_player_in_hltv #120
Conversation
src/hooks/engine.rs
Outdated
| let cmd_function = &*curr_cmd_function; | ||
| let curr_name = CStr::from_ptr(cmd_function.name as *mut i8); | ||
|
|
||
| if curr_name.to_str().ok()? == name { |
There was a problem hiding this comment.
This shouldn't early-return upon to_str() failure, it just means we need to skip this cmd.
| if curr_name.to_str().ok()? == name { | |
| if curr_name.to_str() == Some(name) { |
src/modules/show_player_in_hltv.rs
Outdated
| && engine::ClientDLL_IsThirdPerson.is_set(marker) | ||
| && engine::CL_IsSpectateOnly.is_set(marker) | ||
| && engine::pmove.is_set(marker) | ||
| && unsafe { engine::find_cmd(marker, "dem_forcehltv") }.is_some() |
There was a problem hiding this comment.
Hmm, I don't like this logic involving some engine state in is_enabled(). Perhaps should find this somewhere similar to how we find pointers?
There was a problem hiding this comment.
These HLTV and demo codes are inside demoplayer.so (or at the very least, not inside engine code). I don't see any references to static HLTV variables inside engine. The reason why there is cvar check in the first place is because BXT does it. I suspect it is to avoid crashing or unintended behaviors. @SmileyAG may know why it is needed.
Anyways, if it doesn't look like what you want, it is possible to store a static variable caching the result of this find_cmd during run time to check that dem_forcehltv actually exists.
src/modules/show_player_in_hltv.rs
Outdated
|
|
||
| This is the fix for that. | ||
|
|
||
| Alternatively, with this fix, it is possible to use `playdemo` with `thirdperson` to have the player model show up to just record. \ |
There was a problem hiding this comment.
Does this mean the dem_forcehltv 1 check is not needed?
There was a problem hiding this comment.
No you don't need that check. dem_forcehltv 1 is for viewdemo. When you do playdemo, forcing HLTV doesn't do anything.
There was a problem hiding this comment.
Then maybe remove the whole dem_forcehltv check and find_cmd?
There was a problem hiding this comment.
Ah, I guess I didn't explain that clearly.
To view the player model when playing back a demo, there are two ways. The first way is doing playdemo and thirdperson. You don't have free camera movement with that. The second way is viewdemo with dem_forcehltv 1. With that, you have free camera movement.
The playdemo route is for straightforward loading a campath and then recording. The viewdemo route is for looking around and seeing what you might want to do.
I think it is possible to just remove the dem_forcehltv and then find_cmd. That wouldn't reduce any functionalities. It is just that the original BXT implementation has this check so I just have it there to make sure things are on parity. And again, tagging @SmileyAG here and hope he can explain why he has it in his implementation.
|
After some more testing on this, it seems like The reason why this PR/fix exists is so that people can record a demo in third person. Personally, after learning that |
|
If I wrote ok, then commit via github UI and let's merge |
Co-authored-by: Ivan Molodetskikh <[email protected]>
Co-authored-by: Ivan Molodetskikh <[email protected]>
|
Let's do it. |
|
Thanks |
closes #117
The implementation is very similar to BXT. I also realize that I have been taking this feature for granted, recording a few demos with this feature without knowing it is a feature.
There is
Cmd_FindCmdbut I just feel like it is easier to just implement my own.