Fix GitHub Actions environment handling for MCP resource decorators #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decorators Fix GitHub Actions test failures caused by new MCP resource decorators trying to access environment variables during module import. The decorators added in commit dd7869e were causing CI failures because environment variables aren't configured in the testing environment. Changes: - Add ValueError exception handling in _read_resource_content() - Return graceful "unavailable" response when environment not configured - Preserve full functionality when environment variables are properly set - All 230 tests continue to pass in both local and CI environments Root cause: New @mcp.resource decorators execute during module import, triggering CyberArkMCPServer.from_environment() which requires credentials not available in CI. This fix ensures the decorators don't break testing while maintaining production functionality.
… mode Fix the workflow installation step to use `pip install -e .` instead of `pip install -r requirements.txt`. This ensures the mcp_privilege_cloud package is properly installed and importable during testing. Root cause: Tests were failing with "ModuleNotFoundError: No module named 'mcp_privilege_cloud'" because only external dependencies were installed, but not the package itself. Validated with act: - ❌ Before: Reproduced exact GitHub Actions failure locally - ✅ After: All 230 tests pass in act environment (same as GitHub Actions) This follows Python packaging best practices for testing packages.
- Add explicit environment variable validation in test workflow - Enhance error reporting with detailed environment variable status - Improve debugging capabilities for CI/CD troubleshooting - Maintain backward compatibility with existing workflow structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix GitHub Actions test failures caused by new MCP resource decorators trying to access environment variables during module import.
_read_resource_content()Root Cause
The new
@mcp.resourcedecorators added in commit dd7869e execute during module import, triggeringCyberArkMCPServer.from_environment()which requires CyberArk credentials not available in the CI testing environment.Test Plan
Changes
ValueErrorexception handling for missing environment variablesThis ensures the new MCP resource decorators don't break testing environments while maintaining full functionality in production.