Skip to content

Compat 3CB Factions - Add trenches Compatibility #10915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Andx667
Copy link
Contributor

@Andx667 Andx667 commented May 13, 2025

When merged this pull request will:

  • Add Entrenchingtool to three Backpacks
  • Add 3CB Factions to launch.toml

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@Andx667 Andx667 changed the title compat_3cb_factions - Add trenches Compatibility Compat 3CB Factions - Add trenches Compatibility May 13, 2025
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label May 13, 2025
@Andx667 Andx667 marked this pull request as ready for review May 13, 2025 16:34
@Andx667
Copy link
Contributor Author

Andx667 commented May 13, 2025

There are some Backpacks that could be included, like this:
202505~1

Its clearly the pouch for an E-Tool, but I'm leaning on leaving them out. Thoughts?

@rautamiekka
Copy link
Contributor

There are some Backpacks that could be included, like this: [...]

Its clearly the pouch for an E-Tool, but I'm leaning on leaving them out. Thoughts?

My vote: include. I think most would prefer the pouch being used for its purpose by default.

@Andx667 Andx667 marked this pull request as draft May 15, 2025 19:33
Copy link
Contributor Author

@Andx667 Andx667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added more Backpack as per your argument. Just need to check the Addon the original 3 come from to add to the config.cpp and its ready for review

class TFAR_mr3000;
class TFAR_rt1523g_big;

class UK3CB_B_I_Alice_pack_frame_radio_01: TFAR_anprc155 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these base classes exist without loading TFAR

@Andx667 Andx667 marked this pull request as ready for review May 16, 2025 09:10
@PabstMirror PabstMirror added this to the 3.20.0 milestone May 16, 2025
@johnb432
Copy link
Contributor

I have mixed feelings about adding a compat for 3CB mods, as they provide most of the ACE compat already. Furthermore, it adds extra maintenance.
If 3CB has stopped developing for Arma 3 (or only minor updates come out, like for RHS towards the end) then the maintenance isn't an issue, so I'd be fine with adding missing or correcting existing ACE compat.

@Andx667
Copy link
Contributor Author

Andx667 commented May 17, 2025

I can understand that. The last Update for 3CB Equipment ist from Jan 2022. It seems unlikely to me there is a major update coming.

Sorry got confused by the 2 PRs. 3CB Factions seems somewhat active. I ok with not merging this.

@PabstMirror PabstMirror modified the milestones: 3.20.0, Ongoing May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants