Common - Improve - Improve Headers for better clarity for ProgressBar and CanInteractWith #10942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkIsGrim
approved these changes
Jun 2, 2025
johnb432
reviewed
Jun 5, 2025
| @@ -6,7 +6,7 @@ | |||
| * Arguments: | |||
| * 0: The player. <OBJECT> | |||
| * 1: The interaction target. objNull to ignore. <OBJECT> | |||
| * 2: Exceptions. What general conditions are to skip? (default: []) <ARRAY> | |||
| * 2: Exceptions. What general conditions are to skip? (works like a permission system, if there is an exception, it will return true)(default: []) <ARRAY> | |||
There was a problem hiding this comment.
Imo this could be interpreted as "if one condition is true, then it will succeed" (= OR) instead of being AND.
Co-authored-by: johnb432 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.