fix: close connection after receiving GO_AWAY from remote #3678
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found it difficult to write a suitable test, we would need to shut down the h2 connection gracefully after it has been established and before sending the response. Do you have an idea how to achieve that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug Fix
PR_TYPE
PR Checklist
Overview
If the remote gracefully shuts down a HTTP/2 connection by sending GO_AWAY, the corresponding h2 error is returned.
Before this change, the connection remained in the pool and using it again results in the same h2 error.
With this change the connection is released from the pool as intended by the remote.