fix: replace invalid /raindrops endpoint with /raindrops/0 #21
Conversation
- Fixes bookmark_search 404 errors - searchRaindrops now uses valid /raindrops/0 endpoint - Aligns with working getBookmarks implementation - Validated against live Raindrop.io API
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jcontini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug that prevented the bookmark_search functionality from operating correctly. The change involves a precise correction to an API endpoint, ensuring that bookmark searches now successfully retrieve results instead of returning 404 errors. This fix restores expected functionality and improves the reliability of the bookmark search feature.
Highlights
- Bug Fix: Resolved 404 errors encountered by the
bookmark_searchtool, which was failing due to an incorrect API endpoint. - API Endpoint Correction: Updated the
searchRaindropsmethod insrc/services/raindrop.service.tsto use the correct/raindrops/0endpoint, aligning it with the functionalgetBookmarksimplementation and the Raindrop.io API documentation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a 404 error in the searchRaindrops method by changing the API endpoint from /raindrops to /raindrops/0. The fix is correct for searches across all bookmarks. However, this change doesn't account for searches within a specific collection, as the collection parameter is not used to build the URL. I've suggested an improvement to dynamically construct the endpoint, which will fix this bug and align the behavior more closely with the getBookmarks method.
| @@ -468,7 +468,7 @@ class RaindropService { | |||
| delete queryParams.createdEnd; | |||
| } | |||
|
|
|||
| const { data } = await this.api.get('/raindrops', { | |||
| const { data } = await this.api.get('/raindrops/0', { | |||
There was a problem hiding this comment.
The change fixes the 404 error, but it doesn't fully align with the getBookmarks method's logic for handling collections. The searchRaindrops method will now always query /raindrops/0 (all bookmarks), even when a specific collection ID is passed. This means the collection parameter is effectively ignored.
To ensure searches can be scoped to a specific collection (including collection 0 for "Unsorted"), the endpoint URL should be constructed dynamically, checking if params.collection is defined.
| const { data } = await this.api.get('/raindrops/0', { | |
| const { data } = await this.api.get(params.collection !== undefined ? `/raindrops/${params.collection}` : '/raindrops/0', { | |
🐛 Problem
The
bookmark_searchtool was returning 404 errors because thesearchRaindropsmethod was calling an invalid/raindropsendpoint.🔧 Solution
Changed the endpoint from
/raindropsto/raindrops/0in thesearchRaindropsmethod, aligning it with the workinggetBookmarksimplementation.✅ Testing
bookmark_searchnow returns results instead of 404 errors📝 Changes
src/services/raindrop.service.ts: Line 471 - Changed/raindropsto/raindrops/0This fix makes the bookmark search functionality work as expected and aligns with the Raindrop.io API documentation.