Skip to content

DRAFT: Animations wip #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 89 commits into
base: main
Choose a base branch
from
Open

DRAFT: Animations wip #499

wants to merge 89 commits into from

Conversation

c-lamoureux
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

gideontonkinson and others added 30 commits January 16, 2025 17:19
@gideontonkinson @c-lamoureux
feat: add timer value to signals (#127)
8c67df1 
* chore: add timer value to signals

* fix: remove debug from chart.story.tsx

* chore: add tests for timer signal

* fix: remove debug
@gideontonkinson @c-lamoureux
Gtonkinson/animations (#132)
181602c 
* chore: add timer value to signals

* fix: remove debug from chart.story.tsx

* chore: add tests for timer signal

* fix: remove debug

* feat: add previous data table to data

* fix: fix broken test

* fix: remove debug
@Judd2000 @c-lamoureux
Merge remote to local
d6b91c3
@Judd2000 @c-lamoureux
Animations implement from zero and using previous data
92fa59d
@Judd2000 @c-lamoureux
Animations Between Data: starting implementation
bbc2374
@Judd2000 @c-lamoureux
Animations finished new-old data animations for line chart
4ac548b
@Judd2000 @c-lamoureux
Animations remove todo
3b7339a
@Judd2000 @c-lamoureux
Animations added static line animations and removed lint issues
70cec24
@Judd2000 @c-lamoureux
Animations stacked bar and areas animations added)
e3404e6
@Judd2000 @c-lamoureux
Animations dodged bar experimentaion
52c7c6a
@Judd2000 @c-lamoureux
Animations add dodged bar-specific animations as well as hide labels …
cba7139 
…until animations finished
@Judd2000 @c-lamoureux
Animations lint fixes
daf162d
@Judd2000 @c-lamoureux
Animations use structuredClone instead of JSON.stringify
12db9be
@Judd2000 @c-lamoureux
Animations added global mock for structuredClone
333462b
@jacob-hart @c-lamoureux
Add animation easing
4dc4ad3
@Judd2000 @c-lamoureux
Animations fixed previousData causing strange animations
c29023b
@Judd2000 @c-lamoureux
Animations fix previousData, add filter
e5e873b
@jacob-hart @c-lamoureux
Add animation spec backwards compatibility with existing tests (#169)
ce90801 
* Remove console.warn

* Fix areaUtil tests

* Fix areaSpecBuilder tests

* Update linePointUtils to avoid creating unnecessary keys

* Fix lineMarkUtils tests

* Fix lineSpecBuilder tests

* Fix bar tests

* Fix metricRangeUtils tests
@Judd2000 @c-lamoureux
Animations fix (most) remaining tests
b2ba790
@Judd2000 @c-lamoureux
Animation resolve new test data expected lengths
3f90ff1
@jacob-hart @c-lamoureux
Change animation duration (#198)
862252b 
Change animation duration and use constants instead of magic numbers
@Judd2000 @c-lamoureux
Animations disable animations for the dodged trellis bar
5bddeb1
@Judd2000 @c-lamoureux
Animations re-add semicolon
d34ca1c
@Judd2000 @c-lamoureux
Animations disabled animations on animation-supported chart types
f5d5108
@Judd2000 @c-lamoureux
Animations remove unused import
af8a722
@gideontonkinson @c-lamoureux
chore: add timer value to signals
3000172
@gideontonkinson @c-lamoureux
fix: remove debug from chart.story.tsx
9daf4ef
@gideontonkinson @c-lamoureux
chore: add tests for timer signal
b71709c
@gideontonkinson @c-lamoureux
fix: remove debug
76c8dd5
@gideontonkinson @c-lamoureux
feat: add previous data table to data
eb03ef0
Judd2000 and others added 28 commits January 17, 2025 14:57
@Judd2000 @c-lamoureux
Animations pass animations to scatterSpecBuilder, add animations togg…
49ed9cf 
…le to scatter
@Judd2000 @c-lamoureux
Animations removed nested ternary inside markUtils
a573677
@Judd2000 @c-lamoureux
Animations fixed tests to not expect timerValue when animations are offA
81192a9
@gideontonkinson @c-lamoureux
fix: remove todo where tests are already implemented
9f168de
@agardn87 @c-lamoureux
Replace timer value with constant
f07a196
@agardn87 @c-lamoureux
Add animation toggle to opacity animation stories
084a7e3
@Judd2000 @c-lamoureux
Animatioins moved usePreviousChartData out to the react hooks directo…
ba98b12 
…ry - removed generics in favor of ChartData[]
@Judd2000 @c-lamoureux
Animations removed console.warn
038c332
@Judd2000 @c-lamoureux
Animations removed unnecessary const
712ba18
@gideontonkinson @c-lamoureux
fix unneccessary logic
69649e4
@gideontonkinson @c-lamoureux
remove todo where tests are already completed
5c8bbe2
@gideontonkinson @c-lamoureux
add more testing
5dae4ea
@gideontonkinson @c-lamoureux
removed unneccessary todos
3bc062d
@jacob-hart @c-lamoureux
Use mark id for animations
f98e294
@jacob-hart @c-lamoureux
Remove unused imports
d5ccb51
@gideontonkinson @c-lamoureux
remove added console.logs
13fa36b
@Judd2000 @c-lamoureux
Animations more logical suggestion fixes
5f33730
@Judd2000 @c-lamoureux
Animations removed commented code and uneccessary space
2301127
@gideontonkinson @c-lamoureux
remove warns
2d97cba
@gideontonkinson @c-lamoureux
remove more todos
9bf174c
@gideontonkinson @c-lamoureux
remove documentation todo
a4f0383
@gideontonkinson @c-lamoureux
fixed nested turnerary
aea34c6
@Judd2000 @c-lamoureux
Animations removed useMemo wrapping the VegaChart component
34c04fb
@Judd2000 @c-lamoureux
Animations moved onNewView inline lambda to const
a4f73f1
@Judd2000 @c-lamoureux
Animation set SharedChartProps animations to optional, added necessar…
018025e 
…y check to rscChart (even though it will always be defined by that point)
@Judd2000 @c-lamoureux
Animations switched to ?? instead of comparing against undefined
4767ba6
@c-lamoureux
chore: cleanup animations
a238e4b
@c-lamoureux
chore: code formatting
6dafc18
@c-lamoureux c-lamoureux changed the title DRAFT: Animations wip DO NOT MERGE: Animations wip Jan 23, 2025
@c-lamoureux c-lamoureux changed the title DO NOT MERGE: Animations wip DRAFT: Animations wip Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c-lamoureux @gideontonkinson @Judd2000 @jacob-hart @agardn87