chore(python-sdk): modernise type hints #55
+61
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
changed the title
stevenh
force-pushed
the
core/modern-union
branch
2 times, most recently
from
6f2b6a7 to
a4a8daf
Compare
Leverage __future__ import annotations to enable support for streamlined type hints using | vs Union from PEP 604. Future annotations was enabled across the codebase so that any additional use of Optional or Union would be flagged by type linters. Removed unused imports, guarded import under TYPE_CHECKING where necessary. Fixed accept parameter definition for EventEncoder and added a missing comment. Fixes: ag-ui-protocol#50
stevenh
force-pushed
the
core/modern-union
branch
from
a4a8daf to
f492e53
Compare
There was a problem hiding this comment.
Pull Request Overview
Modernize type hints across the Python SDK by enabling postponed evaluation of annotations, replacing Union/Optional with |, cleaning up imports, and tightening the EventEncoder initializer.
- Add
from __future__ import annotationsand use PEP 604 unions everywhere. - Remove unused imports and guard imports under
TYPE_CHECKING. - Update
EventEncoder.__init__signature and add a basic docstring.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python-sdk/tests/test_types.py | Added future annotations import for streamlined type hints. |
| python-sdk/tests/test_events.py | Added annotations import; removed unused json and Message. |
| python-sdk/tests/test_encoder.py | Added future annotations import. |
| python-sdk/ag_ui/encoder/encoder.py | Guarded event type import, updated __init__ signature and doc. |
| python-sdk/ag_ui/encoder/init.py | Added future annotations import. |
| python-sdk/ag_ui/core/types.py | Replaced Union/Optional with ` |
| python-sdk/ag_ui/core/events.py | Replaced Optional[...] with ` |
| python-sdk/ag_ui/core/init.py | Added future annotations import. |
Comments suppressed due to low confidence (1)
python-sdk/ag_ui/encoder/encoder.py:20
- Expand this docstring to document the
acceptparameter (its purpose, valid values, and default behavior) to improve clarity for future readers.
"""
Initializes the EventEncoder.
"""
|
@NathanTarbert @mme could you have a look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage future import annotations to enable support for streamlined type hints using | vs Union from PEP 604.
Future annotations was enabled across the codebase so that any additional use of Optional or Union would be flagged by type linters.
Removed unused imports, guarded import under TYPE_CHECKING where necessary.
Fixed accept parameter definition for EventEncoder and added a missing comment.
Fixes: #50