Skip to content

fix: various connector icons #63371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: various connector icons #63371

wants to merge 7 commits into from

Conversation

joeykmh
Copy link
Contributor

@joeykmh joeykmh commented Jul 18, 2025 •
edited
Loading

What

I noticed that in Firefox, any connector icons missing a width or height attribute will not display properly. For example:

image

I used claude code to update any icons with missing width and height attributes with width="250" height="250". This makes them display properly in firefox:

image

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 11:51am

@github-actions GitHub Actions
Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
  • /poe source example lock - Alias for /poe connector source-example lock.
  • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
  • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

@joeykmh joeykmh changed the title fixed with claude fix: various connector icons Jul 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

destination-vectara Connector Test Results

0 tests   0 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

destination-cumulio Connector Test Results

64 tests   61 ✅  2s ⏱️
 2 suites   2 💤
 2 files     1 ❌

For more details on these failures, see this check.

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

destination-rabbitmq Connector Test Results

9 tests   6 ✅  2s ⏱️
2 suites  2 💤
2 files    1 ❌

For more details on these failures, see this check.

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

destination-milvus Connector Test Results

15 tests   12 ✅  6s ⏱️
 2 suites   2 💤
 2 files     1 ❌

For more details on these failures, see this check.

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-genesys Connector Test Results

23 tests   22 ✅  1s ⏱️
 2 suites   0 💤
 2 files     0 ❌  1 🔥

For more details on these errors, see this check.

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-google-drive Connector Test Results

1 tests   0 ✅  7s ⏱️
1 suites  0 💤
1 files    0 ❌  1 🔥

For more details on these errors, see this check.

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-gainsight-px Connector Test Results

5 tests   2 ✅  6s ⏱️
1 suites  3 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-microsoft-onedrive Connector Test Results

0 tests   0 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

destination-surrealdb Connector Test Results

12 tests   9 ✅  6s ⏱️
 2 suites  2 💤
 2 files    1 ❌

For more details on these failures, see this check.

Results for commit 36d6b90.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

destination-surrealdb Connector Test Results

12 tests   9 ✅  7s ⏱️
 2 suites  2 💤
 2 files    1 ❌

For more details on these failures, see this check.

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-awin-advertiser Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-calendly Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-breezy-hr Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-campaign-monitor Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-cloudbeds Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-snowflake Connector Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-coassemble Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-freshchat Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-hoorayhr Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-jamf-pro Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-luma Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-mention Connector Test Results

3 tests   1 ✅  4s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-microsoft-lists Connector Test Results

3 tests   2 ✅  7s ⏱️
1 suites  1 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-nylas Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-persona Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-repairshopr Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-stockdata Connector Test Results

3 tests   1 ✅  3s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

source-coingecko-coins Connector Test Results

14 tests   9 ✅  2h 42m 43s ⏱️
 1 suites  4 💤
 1 files    1 ❌

For more details on these failures, see this check.

Results for commit 95d552b.

♻️ This comment has been updated with latest results.

@joeykmh
Copy link
Contributor Author

joeykmh commented Jul 21, 2025

@dbgold17 would you be able to take a quick look here today? Since I'm touching so many connector docs for the version bump, I'm running into conflicts pretty quickly 😄

@joeykmh joeykmh requested a review from dbgold17 July 21, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbgold17 dbgold17 Awaiting requested review from dbgold17

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
connectors/destination/cumulio connectors/destination/milvus connectors/destination/rabbitmq connectors/destination/starburst-galaxy connectors/destination/surrealdb connectors/destination/vectara connectors/destination/yellowbrick connectors/source/awin-advertiser connectors/source/breezy-hr connectors/source/calendly connectors/source/campaign-monitor connectors/source/cloudbeds connectors/source/coassemble connectors/source/coingecko-coins connectors/source/fleetio connectors/source/freshchat connectors/source/gainsight-px connectors/source/genesys connectors/source/google-drive connectors/source/hoorayhr connectors/source/jamf-pro connectors/source/jina-ai-reader connectors/source/luma connectors/source/mention connectors/source/microsoft-lists connectors/source/microsoft-onedrive connectors/source/microsoft-sharepoint connectors/source/nylas connectors/source/persona connectors/source/repairshopr connectors/source/snowflake connectors/source/stockdata connectors/source/tyntec-sms connectors/source/unleash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeykmh @octavia-squidington-iii