Skip to content

Bulk CDK: No supplier for trigger-based connectors #63729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

mwbayley
Copy link
Contributor

This PR modifies the bean injection behavior for sources using the bulk CDK. A recent CDK change introduced the JdbcPartitionCreatorFactorySupplier. This cannot be successfully autowired for trigger-table based sinks in the enterprise repo. Here we instruct Micronaut not to attempt to wire the bean if the execution mode is neither sequential nor concurrent (the two supported directly by the CDK currently).

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@mwbayley mwbayley requested a review from a team as a code owner July 22, 2025 23:44
Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Jul 22, 2025 11:44pm

Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
  • /poe source example lock - Alias for /poe connector source-example lock.
  • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
  • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

Copy link
Contributor

destination-dev-null Connector Test Results

44 tests   12 ✅  38s ⏱️
 4 suites  32 💤
 4 files     0 ❌

Results for commit a73ab59.

Copy link
Contributor

destination-clickhouse Connector Test Results

 15 files   15 suites   3m 1s ⏱️
211 tests 173 ✅ 38 💤 0 ❌
231 runs  193 ✅ 38 💤 0 ❌

Results for commit a73ab59.

Copy link
Contributor

destination-customer-io Connector Test Results

45 tests   15 ✅  22s ⏱️
 7 suites  30 💤
 7 files     0 ❌

Results for commit a73ab59.

Copy link
Contributor

destination-mssql Connector Test Results

129 tests   111 ✅  8m 21s ⏱️
 12 suites   18 💤
 12 files      0 ❌

Results for commit a73ab59.

Copy link
Contributor

source-mysql Connector Test Results

  8 files    8 suites   29s ⏱️
 51 tests  51 ✅ 0 💤 0 ❌
175 runs  175 ✅ 0 💤 0 ❌

Results for commit a73ab59.

Copy link
Contributor

destination-s3 Connector Test Results

677 tests   355 ✅  1h 56m 32s ⏱️
 24 suites  322 💤
 24 files      0 ❌

Results for commit a73ab59.

@mwbayley mwbayley merged commit df1ee16 into master Jul 23, 2025
37 checks passed
@mwbayley mwbayley deleted the mbayley/cdk/unblock-trigger-cdc branch July 23, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants