You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies the bean injection behavior for sources using the bulk CDK. A recent CDK change introduced the JdbcPartitionCreatorFactorySupplier. This cannot be successfully autowired for trigger-table based sinks in the enterprise repo. Here we instruct Micronaut not to attempt to wire the bean if the execution mode is neither sequential nor concurrent (the two supported directly by the CDK currently).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the bean injection behavior for sources using the bulk CDK. A recent CDK change introduced the
JdbcPartitionCreatorFactorySupplier
. This cannot be successfully autowired for trigger-table based sinks in the enterprise repo. Here we instruct Micronaut not to attempt to wire the bean if the execution mode is neither sequential nor concurrent (the two supported directly by the CDK currently).Can this PR be safely reverted and rolled back?