Skip to content

Commit dbc4739

Browse files
committed
Updated readme instructions on desktop build actions
1 parent f15923c commit dbc4739

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

.github/workflows/linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Build Desktop App (Linux - deb)
1+
name: Build Desktop App (Linux .deb)
22

33
on:
44
# push:

.github/workflows/windows.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
name: Build Desktop App (Windows)
1+
name: Build Desktop App (Windows .msi)
22

33
on:
4-
push:
5-
branches:
6-
- master
4+
# push:
5+
# branches:
6+
# - master
77
# pull_request:
88
# branches:
99
# - master
@@ -57,4 +57,4 @@ jobs:
5757
uses: actions/upload-artifact@v4
5858
with:
5959
name: windows
60-
path: dist/bundle/msi/
60+
path: dist/bundle/msi/**/*.msi

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,8 @@ DATABASE_URL
177177

178178
### Desktop
179179

180-
> Github actions for the Linux and MacOS platforms are not yet functioning since `dx bundle` fails with various errors.
180+
> The Github action for MacOS is not yet implemented. Linux is barely functioning since the built bundle fails with various errors (e.g the installed .deb package searches assets in the folder where you call it and not globally). Windows is the only platform that works correctly for now.
181181
182182
- For Windows you can configure the `.github/workflows/windows.yaml` workflow to build and upload the `.msi` installer in the action artifacts on every push to the `master` branch or manually with the `workflow_dispatch` event.
183+
- For Linux you can configure the `.github/workflows/linux.yaml` workflow to build and upload the `.deb` package along with the dist folder in the action artifacts on every push to the `master` branch or manually with the `workflow_dispatch` event.
183184
- Currently `dx bundle` is being actively developed and is not yet ready for production use, so you should use `dx build` if bundling fails on other platforms (this is not good since you need attach the entire `dist` folder to your release build).

0 commit comments

Comments
 (0)