Skip to content

Improve GPU selection #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Improve GPU selection #342

merged 5 commits into from
Feb 24, 2025

Conversation

philogicae
Copy link
Member

@philogicae philogicae commented Feb 19, 2025

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

TODO

  • Better CRN x GPU selection (all at once)
  • Rework on GPU tests
  • Minor fixes & improvements

Changes

Before: Choose CRN, then GPU device

image

After: Choose target CRN + GPU device all at once

image
image

@philogicae philogicae requested a review from nesitor February 19, 2025 17:31
@philogicae philogicae marked this pull request as draft February 19, 2025 17:39
@philogicae philogicae self-assigned this Feb 19, 2025
Copy link

Failed to retrieve llama text: POST 500: 500: Unhandled error during initialisation

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 69.38776% with 15 lines in your changes missing coverage. Please review.

Project coverage is 60.44%. Comparing base (41575ac) to head (dcb6caf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/instance/__init__.py 77.50% 5 Missing and 4 partials ⚠️
src/aleph_client/commands/instance/display.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   58.68%   60.44%   +1.75%     
==========================================
  Files          18       18              
  Lines        3113     3107       -6     
  Branches      430      429       -1     
==========================================
+ Hits         1827     1878      +51     
+ Misses       1065     1010      -55     
+ Partials      221      219       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philogicae philogicae marked this pull request as ready for review February 24, 2025 11:11
Copy link

Failed to retrieve llama text: POST 500: 500: Unhandled error during initialisation

@philogicae philogicae merged commit effa2ea into master Feb 24, 2025
15 checks passed
@philogicae philogicae deleted the improve-gpu-selection branch February 24, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants