Skip to content

Fix program chain and UX #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix program chain and UX #343

merged 2 commits into from
Feb 24, 2025

Conversation

philogicae
Copy link
Member

Depends on this SDK PR

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Documentation

Will be regenerated after all PRs are merged.

Changes

  • Display pricing for each program in list
  • Fix payment chain -> SOL wasn't working properly
  • Simplify tests after Annotated update

Screenshots

image

@philogicae philogicae self-assigned this Feb 20, 2025
@philogicae philogicae force-pushed the fix-program-chain-and-ux branch from b7010a2 to f264588 Compare February 20, 2025 12:08
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 60.52%. Comparing base (effa2ea) to head (0bd5f06).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/program.py 76.31% 4 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   60.31%   60.52%   +0.20%     
==========================================
  Files          18       18              
  Lines        3107     3136      +29     
  Branches      429      434       +5     
==========================================
+ Hits         1874     1898      +24     
  Misses       1014     1014              
- Partials      219      224       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philogicae philogicae requested a review from nesitor February 20, 2025 12:15
Copy link

Failed to retrieve llama text: POST 500: 500: Unhandled error during initialisation

@philogicae philogicae force-pushed the fix-program-chain-and-ux branch from f264588 to 2fd6fc6 Compare February 20, 2025 12:22
@philogicae philogicae force-pushed the fix-program-chain-and-ux branch from 2fd6fc6 to 0bd5f06 Compare February 24, 2025 13:31
@philogicae philogicae merged commit e770682 into master Feb 24, 2025
14 checks passed
@philogicae philogicae deleted the fix-program-chain-and-ux branch February 24, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants