Skip to content

Allow extended rootfs size + Alert for unstarted PAYG VMs #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 26, 2025

Conversation

philogicae
Copy link
Member

@philogicae philogicae commented Feb 20, 2025

Jira tasks: ALEPH-428 & ALEPH-427

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Docs

Changes

ALEPH-428

  • Allow to increase rootfs size (larger than default tier) + fixes/checks

ALEPH-427

  • Display explicit alerts for unallocated PAYG VMs with active flows and unstarted coco VMs

Extra fixes

  • Fix volumes once for all and display them
  • Add volumes to instance test
  • Mention GPU instances are PAYG only in helper

Screenshots

Extended rootfs and volumes

image

Alert for unallocated/unstarted instance(s) with active flows

image

@philogicae philogicae requested a review from nesitor February 20, 2025 13:28
@philogicae philogicae self-assigned this Feb 20, 2025
Copy link

Failed to retrieve llama text: POST 500: 500: Unhandled error during initialisation

Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we add a prompt question to the user on the creation flow requiring to the user to set the disk size, putting the tier size by default but allowing him to increase it more explicitly than just sending the param?

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 72.09302% with 24 lines in your changes missing coverage. Please review.

Project coverage is 61.28%. Comparing base (e770682) to head (8766d48).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/utils.py 70.00% 10 Missing and 5 partials ⚠️
src/aleph_client/commands/instance/__init__.py 71.42% 3 Missing and 3 partials ⚠️
src/aleph_client/commands/pricing.py 71.42% 0 Missing and 2 partials ⚠️
src/aleph_client/commands/program.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   60.58%   61.28%   +0.70%     
==========================================
  Files          18       18              
  Lines        3136     3167      +31     
  Branches      434      445      +11     
==========================================
+ Hits         1900     1941      +41     
+ Misses       1013      989      -24     
- Partials      223      237      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olethanh olethanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before it was possible to specify multiple volume by repeating the command. eg aleph program create --immutable-volume abc --immutable-volume bcd

But now the syntax changed and it is necessary to use something like --immutable-volume abc#bcd don't know if it is on purpose? The feature before was not documented

@philogicae philogicae force-pushed the fix-custom-rootfs-size branch from 677fd2f to cbf7958 Compare February 24, 2025 15:23
@philogicae
Copy link
Member Author

Before it was possible to specify multiple volume by repeating the command. eg aleph program create --immutable-volume abc --immutable-volume bcd

But now the syntax changed and it is necessary to use something like --immutable-volume abc#bcd don't know if it is on purpose? The feature before was not documented

Indeed, Fixed!

@philogicae philogicae force-pushed the fix-custom-rootfs-size branch from 19fde67 to 113e19b Compare February 24, 2025 18:17
@philogicae philogicae changed the title Allow rootfs size larger than default tier Allow extended rootfs size + Alert for unstarted PAYG VMs Feb 24, 2025
@philogicae philogicae force-pushed the fix-custom-rootfs-size branch from 113e19b to 8766d48 Compare February 24, 2025 18:29
@olethanh olethanh merged commit ed3dc8b into master Feb 26, 2025
14 checks passed
@philogicae philogicae deleted the fix-custom-rootfs-size branch February 26, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants