Fix: missing try catch on aleph file upload #365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self proofreading checklist
Changes
This pull request introduces error handling for the
upload
function insrc/aleph_client/commands/files.py
to provide more informative feedback when file uploads fail. It also includes a minor import statement update.Error handling improvements:
try-except
block in theupload
function to catchClientResponseError
exceptions during file uploads. This ensures that specific error messages are displayed to the user, such as notifying them when a file is too large to upload (status: 413
) or providing a generic error message for other cases. [1] [2]Import updates:
ClientResponseError
fromaiohttp
to support the new error handling in theupload
function.How to test
aleph file upload
with file > than 100 MiB or with a wallet without balancec