Skip to content

Remove datetime field from message confirmations response #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Apr 10, 2025

Fix: Remove datetime field from message confirmations as on the current implementation it is not exported.

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Remove datetime field from message confirmations as on the current implementation it is not exported.

How to test

Check that url http://51.159.223.120:4024/api/v0/messages/6a2abc608800c6063b93f1a99a9683052015d29830725d5300b0009de0668f4e and ensure that the datetime field it's not exported on message confirmations.

@nesitor nesitor requested review from amalcaraz and 1yam April 10, 2025 14:35
@nesitor nesitor self-assigned this Apr 10, 2025
@nesitor nesitor force-pushed the andres-fix-remove_datetime_field branch from 5b0e647 to e8960b3 Compare April 10, 2025 14:38
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor merged commit 818532b into main Apr 10, 2025
5 checks passed
@nesitor nesitor deleted the andres-fix-remove_datetime_field branch April 10, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants