Skip to content

Solve issue on account files endpoint #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Apr 25, 2025

Fix: Solved 500 error on account files validation endpoint.

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Added list casting on files using the TypeAdapter pattern on Pydantic V2

How to test

Check that endpoint replacing the host by the CCN to see that answers well:
http://51.159.223.120:4024/api/v0/addresses/0x1c50a56c6D473f5ff35798e6397dEaB81157307b/files

@nesitor nesitor requested review from aliel, amalcaraz and 1yam April 25, 2025 08:14
@nesitor nesitor self-assigned this Apr 25, 2025
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor merged commit a80b91c into main Apr 28, 2025
5 checks passed
@nesitor nesitor deleted the andres-fix-solve_files_validation_error branch April 28, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants