Skip to content

Garbage collection failure proof #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented May 15, 2025

Fix: Solve garbage collection deleting issues that raises individually and stops the garbage process.

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

  • Added a try catch for every file to avoid aborting the entire garbage collection process only caused by one file error.

How to test

Execute pyaleph and check that garbage collection runs smoothly and well.

@nesitor nesitor requested review from aliel and amalcaraz May 15, 2025 12:16
@nesitor nesitor self-assigned this May 15, 2025
@nesitor nesitor force-pushed the andres-fix-isolate_garbage_collection_errors branch from cfe6a13 to d329cbf Compare May 15, 2025 12:19
Copy link
Collaborator

@amalcaraz amalcaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor merged commit 5b36122 into main May 15, 2025
5 checks passed
@nesitor nesitor deleted the andres-fix-isolate_garbage_collection_errors branch May 15, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants