fix(clients): reduce chances of Push rate limiting #5153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
force-pushed
the
fix/push-rate-limit
branch
from
90a325e to
1a5d52f
Compare
shortcuts
force-pushed
the
fix/push-rate-limit
branch
from
18789dd to
07ff816
Compare
algolia-bot
added a commit
that referenced
this pull request
Jul 23, 2025
…) [skip ci] Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Jul 23, 2025
algolia/api-clients-automation#5153 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jul 23, 2025
algolia/api-clients-automation#5153 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jul 23, 2025
algolia/api-clients-automation#5153 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jul 23, 2025
algolia/api-clients-automation#5153 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Jul 23, 2025
algolia/api-clients-automation#5153 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-4062
Changes included:
the current implementation let no time for the rate limiting rules to breathe, since we are only waiting for the tasks after every batch have been sent to the api, but for some customer that send e.g. 1_000_000 records, they'd hit that 500 RPM limit quite quickly, before even finishing sending the records to process.
this pr updates the helper code of every clients in order to wait every
batchSize/10API calls, this smoothes the load a bit and potentially let the rule reset, we could even make that10configurable to give more control over potentially rate limited customers.