Skip to content

fix(specs): value/price clarifications in the Insights API #5154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

fix(specs): value/price clarifications in the Insights API #5154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e4868d
fix: value/price clarifications
kai687 Jul 22, 2025
239b6df
fix: value is a sum of all items
kai687 Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions specs/insights/common/schemas/EventAttributes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ positions:
example: [1, 2, 5]

price:
description: Total price of a product, including any discounts, in units of `currency`.
description: Final price of a single product, including any discounts, in units of `currency`.
oneOf:
- type: number
format: double
Expand Down Expand Up @@ -179,7 +179,9 @@ currency:
example: EUR

value:
description: Total monetary value of this event in units of `currency`.
description: |
Total monetary value of this event in units of `currency`.
This should be equal to the sum of `price` times `quantity`.
oneOf:
- type: number
format: double
Expand Down