Skip to content

Conversation

EveryAndrey
Copy link

@EveryAndrey EveryAndrey commented Oct 19, 2023

Context

When for gRPC stream Response wasn't called onNext() before onComplete() (that is a valid case) then we got NPE at row
'requireNonNull(responseAttachmentBuilder).setStatus(status.toString());' because it expects only single or multiple response values.

Checklist

@baev baev added the type:bug Something isn't working label Oct 26, 2023
@dtuchs
Copy link

dtuchs commented Mar 2, 2024

@baev @EveryAndrey it is fixed in #1015
Methods private <T, A> GrpcRequestAttachment.Builder requestAttachment(final MethodDescriptor<T, A> method)
and
private <T, A> GrpcResponseAttachment.Builder responseAttachment(final MethodDescriptor<T, A> method, final io.grpc.Status status, final Metadata metadata)
just return empty array attachement ( []) for epmty streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants