Skip to content

Introduce post-connection timeout setting #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduce post-connection timeout setting #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ function connect(url, socketOptions, openCallback) {

var noDelay = !!sockopts.noDelay;
var timeout = sockopts.timeout;
var postConnectTimeout = sockopts.postConnectTimeout || 300000
var keepAlive = !!sockopts.keepAlive;
// 0 is default for node
var keepAliveDelay = sockopts.keepAliveDelay || 0;
Expand Down Expand Up @@ -145,9 +146,8 @@ function connect(url, socketOptions, openCallback) {

var c = new Connection(sock);
c.open(fields, function(err, ok) {
// disable timeout once the connection is open, we don't want
// it fouling things
if (timeout) sock.setTimeout(0);
// revert to post-connection timeout (typically requires longer timeouts)
sock.setTimeout(postConnectTimeout);
if (err === null) {
openCallback(null, c);
}
Expand Down