New project AD916x & dac_fmc_ebz update #1617
Conversation
- AD916x is a family of DACs - This JESD project was migrated completly from dac_fmc_ebz/project - All the files have been trimmed accordignly, leaving only the relevant code for AD916x (removed unsed contraints, signals etc.) - A documentation page was also created for this project Signed-off-by: Cristian Mihai Popa <[email protected]>
- Removed AD916x and reverted the files affected by the adittion of the DAC family back to the original state - Due to the migration of AD916x out of dac_fmc_ebz, a dedicated doc. page has been created, thus removing all mentions of AD916x from dac_fmc_ebz doc. Signed-off-by: Cristian Mihai Popa <[email protected]>
cristianmihaipopa
requested review from
IuliaCMoldovan,
gastmaier,
StancaPop,
LBFFilho,
AndrDragomir,
bluncan,
acostina,
AndreiGrozav,
PopPaul2021 and
sarpadi
as code owners
Signed-off-by: Cristian Mihai Popa <[email protected]>
There was a problem hiding this comment.
Split into 5 commits:
- bug fix on dac_fmc_ebz (with explanation in the commit body that it reverts another commit and give the ID)
- addition of the ad916x project
- addition of the ad916x documentation
- deletion of the ad916x devices from the dac_fmc_ebz project
- changes for dac_fmc_ebz documentation
After doing all these changes, please retrigger the CI, and wait for the build on all dac_fmc_ebz projects and ad916x to analyze eventual warnings/critical warnings.
| source ../common/dac_fmc_ebz_bd.tcl | ||
|
|
||
| if {[info exists ::env(ADI_LANE_RATE)]} { |
There was a problem hiding this comment.
Was the ADI_LANE_RATE just for the AD916x family? Otherwise, why was it removed?
+ Keep the same alignment of the values as it was before, because this way it is easier to read them.
There was a problem hiding this comment.
Yes, it was. Will fix the alignment.
There was a problem hiding this comment.
Why did you remove the source of dac_fmc_ebz_bd.tcl?
|
Add the project in the CODEOWNERS file, in the commit with the AD916x project addition. The first one should be you and then Paul. |
Signed-off-by: Cristian Mihai Popa <[email protected]>
|
V1: Did all the requested changes. If everything is fine, and no more changes are needed, will structure the commits in 4 big commits as mentioned above. |
Signed-off-by: Cristian Mihai Popa <[email protected]>
Signed-off-by: Cristian Mihai Popa <[email protected]>
| source ../common/dac_fmc_ebz_bd.tcl | ||
|
|
||
| if {[info exists ::env(ADI_LANE_RATE)]} { |
There was a problem hiding this comment.
Why did you remove the source of dac_fmc_ebz_bd.tcl?
Signed-off-by: Cristian Mihai Popa <[email protected]>
|
V2: Did the requested changes |
| dac_jesd204_xcvr 0x84A6_0000 | ||
| dac_jesd204_transport 0x84A0_4000 |
There was a problem hiding this comment.
Swap line 155 with 156
|
|
||
| ### Example configurations | ||
|
|
||
| #### AD9162, TX mode 08 |
There was a problem hiding this comment.
| #### AD9162, TX mode 08 | |
| #### AD9162, TX mode 08 (default) |
| /* | ||
| * Control signals for the FMC boards: | ||
| * | ||
| * dac_ctrl FMC 916x family | ||
| * | ||
| * fmc_txen_0 0 H13 FMC_TXEN_0 | ||
| * fmc_hmc849vctrl 1 D15 FMC_HMC849VCTL | ||
| */ | ||
|
|
There was a problem hiding this comment.
| /* | |
| * Control signals for the FMC boards: | |
| * | |
| * dac_ctrl FMC 916x family | |
| * | |
| * fmc_txen_0 0 H13 FMC_TXEN_0 | |
| * fmc_hmc849vctrl 1 D15 FMC_HMC849VCTL | |
| */ |
PR Description
AD916x (61-64) is a family of DACs which was previously part of dac_fmc_ebz project. It was migrated out and made a separate project. Due to the migration, the following changes were made:
All the devicetrees for each device were merged and support cache coherency. Also, the driver has been updated to fix some issues. The project was tested in hardware.
PR Type
PR Checklist