Skip to content

Conversation

IuliaCMoldovan
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan commented Jul 23, 2025

PR Description

  • projects/cn0577:
    • Added build parameters TWOLANES and ADC_RES
    • Updated the READMEs
  • library/axi_ltc2387:
    • Renamed an internal parameter from RESOLUTION to ADC_RES (to avoid ambiguity)
    • Removed the axi_ltc2387 IP GUI parameters
  • Updated the documentation

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

StancaPop
StancaPop previously approved these changes Jul 30, 2025
- projects/cn0577: Added make parameters ADC_RES (the ADC input
  resolution) and TWOLANES (two-lane mode or one-lane mode). Also fixed
  the sysid parameters logging
- library/axi_ltc2387/axi_ltc2387_if.v: Changed the parameter name RESOLUTION
  to ADC_RES, as it was redundant

Signed-off-by: Iulia Moldovan <[email protected]>
@IuliaCMoldovan
Copy link
Contributor Author

Rebased to latest main

Signed-off-by: Stanca Pop <[email protected]>
Dinamically set the PULSE_1_WIDTH parameter of the axi_ltc2387 IP,
instead of hardcoding it and then overwriting it in software.

Signed-off-by: Stanca Pop <[email protected]>
@IuliaCMoldovan
Copy link
Contributor Author

Removed my commit where I deleted the IP GUI parameters, and replaced it with @StancaPop's commit where she updates the parameters.
Cherry-picked the rest of the code commits from #1870 (the interface update and the addition of the clk_gate_width variable).

@IuliaCMoldovan IuliaCMoldovan changed the title projects/cn0577: Add build parameters and remove IP GUI params projects/cn0577: Add build parameters, update IP GUI Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants