-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(material/sidenav): Deprecated methods used in the responsive sidenav example #29317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lsamboretrorabbit
wants to merge
9
commits into
angular:main
Choose a base branch
from
lsamboretrorabbit:fix-docs-sidenav-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
38fd52f
docs(material/sidenav): Deprecated methods used in the responsive sid…
lsamboretrorabbit 55a0e5d
removed unused
lsamboretrorabbit 178c454
update private variables
lsamboretrorabbit 91ebc75
docs(material/sidenav): Deprecated methods used in the responsive sid…
lsamboretrorabbit 4a11697
docs(material/sidenav): Deprecated methods used in the responsive sid…
lsamboretrorabbit 6234e9f
Merge branch 'main' into fix-docs-sidenav-example
lsamboretrorabbit 719ea46
Revert "Merge branch 'main' into fix-docs-sidenav-example"
lsamboretrorabbit 043595e
docs(material/sidenav): Deprecated methods used in the responsive sid…
lsamboretrorabbit 329b8a6
Merge branch 'main' into fix-docs-sidenav-example
lsamboretrorabbit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 8 additions & 12 deletions
20
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,30 @@ | ||
import {MediaMatcher} from '@angular/cdk/layout'; | ||
import {BreakpointObserver, Breakpoints, MediaMatcher} from '@angular/cdk/layout'; | ||
import {ChangeDetectorRef, Component, OnDestroy} from '@angular/core'; | ||
import {MatListModule} from '@angular/material/list'; | ||
import {MatSidenavModule} from '@angular/material/sidenav'; | ||
import {MatIconModule} from '@angular/material/icon'; | ||
import {MatButtonModule} from '@angular/material/button'; | ||
import {MatToolbarModule} from '@angular/material/toolbar'; | ||
import {Subscription} from 'rxjs'; | ||
import {NgFor} from '@angular/common'; | ||
|
||
/** @title Responsive sidenav */ | ||
@Component({ | ||
selector: 'sidenav-responsive-example', | ||
templateUrl: 'sidenav-responsive-example.html', | ||
styleUrl: 'sidenav-responsive-example.css', | ||
standalone: true, | ||
imports: [MatToolbarModule, MatButtonModule, MatIconModule, MatSidenavModule, MatListModule], | ||
imports: [ | ||
MatToolbarModule, | ||
MatButtonModule, | ||
MatIconModule, | ||
MatSidenavModule, | ||
MatListModule, | ||
NgFor, | ||
], | ||
}) | ||
export class SidenavResponsiveExample implements OnDestroy { | ||
mobileQuery: MediaQueryList; | ||
|
||
fillerNav = Array.from({length: 50}, (_, i) => `Nav Item ${i + 1}`); | ||
|
||
fillerContent = Array.from( | ||
{length: 50}, | ||
() => | ||
|
@@ -29,16 +35,23 @@ export class SidenavResponsiveExample implements OnDestroy { | |
cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.`, | ||
); | ||
|
||
private _mobileQueryListener: () => void; | ||
mobileQuery: boolean; | ||
private breakpointSubscription: Subscription; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that this and |
||
|
||
constructor(changeDetectorRef: ChangeDetectorRef, media: MediaMatcher) { | ||
lsamboretrorabbit marked this conversation as resolved.
Show resolved
Hide resolved
|
||
this.mobileQuery = media.matchMedia('(max-width: 600px)'); | ||
this._mobileQueryListener = () => changeDetectorRef.detectChanges(); | ||
this.mobileQuery.addListener(this._mobileQueryListener); | ||
constructor( | ||
private breakpointObserver: BreakpointObserver, | ||
private changeDetectorRef: ChangeDetectorRef, | ||
) { | ||
this.breakpointSubscription = this.breakpointObserver | ||
.observe([Breakpoints.Handset]) | ||
.subscribe(result => { | ||
this.mobileQuery = result.matches; | ||
this.changeDetectorRef.detectChanges(); | ||
}); | ||
} | ||
|
||
ngOnDestroy(): void { | ||
this.mobileQuery.removeListener(this._mobileQueryListener); | ||
this.breakpointSubscription.unsubscribe(); | ||
} | ||
|
||
shouldRun = /(^|.)(stackblitz|webcontainer).(io|com)$/.test(window.location.host); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.