Remove Commitment Uniqueness Checks #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RM Changes: - Introduce compliance circuit changes - Introduce Payloads into AppData - Change expected forward call info - Simplify the logic instance - Change Digest Computations - Change Resource field types - Change commitment computations - Change nullifier compitations
Unneded due to updated Compliance Unit
agureev
force-pushed
the
feat/remove-double-checks
branch
from
cf0a8b9 to
e4c656b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the updated compliance proof, each committed resource ought to have the corresponding nullifier from its compliance as the nonce.
This grants us uniqueness of commitments automatically given checks for the nullifiers.