feat(Cascader): add classNames & styles props #6865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6865 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 336 336
Lines 7214 7233 +19
Branches 1799 1819 +20
=======================================
+ Hits 6692 6710 +18
- Misses 486 487 +1
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zombieJ
reviewed
May 12, 2025
zombieJ
reviewed
May 16, 2025
keqingrong
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new props for custom class names and inline styles to the Cascader component to enhance its semantic customization capability.
- Updated documentation for Cascader in both Chinese and English.
- Added "classNames" and "styles" props to the CascaderProps and integrated them into the Popup component render.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/cascader/index.zh.md | Added documentation for new props "classNames" and "styles" |
| src/components/cascader/index.en.md | Added documentation for new props "classNames" and "styles" |
| src/components/cascader/cascader.tsx | Introduced new props and integrated them into Popup for styling |
Comments suppressed due to low confidence (1)
src/components/cascader/index.en.md:43
- [nitpick] Consider capitalizing 'DOM' for consistency and clarity in the documentation.
| destroyOnClose | Destroy `dom` when not visible | `boolean` | `true` |
zombieJ
reviewed
Jun 17, 2025
| @@ -50,6 +50,20 @@ export type CascaderProps = { | |||
| onTabsChange?: (index: number) => void | |||
| activeIcon?: ReactNode | |||
| fieldNames?: FieldNamesType | |||
| classNames?: { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.