Skip to content

Fix cowHostList can't have hosts with same ConnectAddress #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dkropachev
Copy link
Contributor

@dkropachev dkropachev commented May 31, 2024

cowHostList uses HostInfo.Equal for host uniqueness, which relies on ConnectAddress.Equal, which does not allow to have different hosts with same ConnectAddress.

It breaks cases like accessing cluster via tcp or ssl proxy

Closes #1757

@dkropachev dkropachev marked this pull request as ready for review May 31, 2024 02:22
Copy link
Contributor

@OleksiienkoMykyta OleksiienkoMykyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please, make it up to date, make the notation to the CHANGELOG.md, and change the commit message according to the CONTRIBUTING.md.
The commit message format should be:

<short description>

<reason why the change is needed>

Patch by <authors>; reviewed by <Reviewers> for CASSGO-#####

NIT: We shouldn't add code that we don't add/change, ConnectAddressAndPort() as an example in this case.

@jameshartig, @joao-r-reis, could we merge it after the update?

cowHostList uses HostInfo.Equal to confirm host uniqueness,
which relies on `ConnectAddress.Equal`, which does not allow to have
different hosts with same `ConnectAddress`
@dkropachev dkropachev force-pushed the fix-hostinfo-uniqueness-logic branch from b2f346a to ddafa1b Compare May 1, 2025 11:50
@dkropachev
Copy link
Contributor Author

dkropachev commented May 1, 2025

LGTM. Please, make it up to date, make the notation to the CHANGELOG.md, and change the commit message according to the CONTRIBUTING.md. The commit message format should be:

<short description>

<reason why the change is needed>

Patch by <authors>; reviewed by <Reviewers> for CASSGO-#####

NIT: We shouldn't add code that we don't add/change, ConnectAddressAndPort() as an example in this case.

@jameshartig, @joao-r-reis, could we merge it after the update?

Done

@joao-r-reis
Copy link
Contributor

I don't want to increase the scope of the 2.0 release but I can add a 2.x fixversion to the JIRA if there is one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cowHostList uses outdated logic for host uniqueness
3 participants