Skip to content

[FLINK-37831] V3.1 do not retry failed index operations #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3.1
Choose a base branch
from

Conversation

thbay
Copy link

@thbay thbay commented May 19, 2025

When using flink-connector-elasticsearch8 ver. 3.1.0-1.20 with flink ver. 1.20.1,
the retry of failed index operations has two problems:

  1. the isRetryable method is testing error.getCause() which is null in case of ConnectException and other exceptions
  2. ELASTICSEARCH_FATAL_EXCEPTION_CLASSIFIER.isFatal() method returns true if exception is not thrown, resulting in the isRetryable() method returns the wrong result.

The committed fix works for me.

@thbay thbay changed the title V3.1 do not retry failed index operations [FLINK-37831] V3.1 do not retry failed index operations May 22, 2025
@reswqa
Copy link
Member

reswqa commented Jun 5, 2025

cc @mtfelisb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants