[FLINK-37737] Add support for GaussDB database type #162
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
...aussdb/src/test/java/org/apache/flink/connector/jdbc/gaussdb/testutils/GaussDBContainer.java
Show resolved
Hide resolved
|
Pls check you files type , used 'int4' instead of 'int1' |
|
Click here to join Jira discuss。 |
Tyhoning
changed the title
There was a problem hiding this comment.
Some minor comments left..
Is GaussDD a postgres syntax compatible? if yes please use CrateDB as reference.
@1996fanrui can you run CI/CD please
| * <p>Notes: The source code is based on CompatiblePostgresDialect. | ||
| */ | ||
| @PublicEvolving | ||
| public abstract class CompatibleGaussdbDialect extends GaussdbDialect { |
There was a problem hiding this comment.
Why this compatible class??
Are GaussDB a postgres syntax compatible database? If yes the GaussDBDialect should extend the CompatiblePostgresDialect, but we dont need to create this classes..
There was a problem hiding this comment.
Thank you very much for your review !
In fact, GaussDB has its own dialect and is not compatible with Postgresql, such as the update syntax.In the future, they will have more incompatibilities.
Add support for GaussDB database type, So you can use Flink jdbc to write to the gaussdb database now。