[hotfix][build & docs] Update version to 4.1-SNAPSHOT and update docs #167
Conversation
| @@ -38,12 +38,27 @@ The JDBC sink operate in upsert mode for exchange UPDATE/DELETE messages with th | |||
| Dependencies | |||
| ------------ | |||
|
|
|||
| When using the JDBC connector, `flink-connector-jdbc-core`, `flink-connector-jdbc-${database}` and the JDBC driver needs to be added to the dependencies. | |||
There was a problem hiding this comment.
nit: needs -> need
nit2:
Is this accurate?
If I want to connect to Derby I need the flink-connector-jdbc-core and the Derby driver.
If I want to connect to DB2 I need the Derby artifact flink-connector-jdbc-coreand the DB2 driver. I assume I do not need the Derby driver.
It might be clearer to say something like. The flink-connector-jdbc-core contains core JDBC capability, it also has built in support for Derby. To use another database , you need to supply it's flink-connector-jdbc-${database} from the same Flink JDBC connector release and the associated JDBC driver.
There was a problem hiding this comment.
I tried the postgres connector and it does not need the jdbc-core .3.30-1.20 from what I see. The jdbc-core and connector-base are transitive depebdencies, at least for lookup joins. I am also willing to fix the comments here if you are busy @ruanhang1993
| See how to link with it for cluster execution [here]({{< ref "docs/dev/configuration/overview" >}}). | ||
| The `flink-connector-jdbc-${database}` dependency and a driver dependency are required to connect to a specified database. | ||
|
|
||
| The `flink-connector-jdbc-${database}` dependencies are as follows, whose version should be the same as the `flink-connector-jdbc-core`: |
There was a problem hiding this comment.
nit: when we say whose version it is not obvious what we mean. I suggest moving it up as per my last comment.
|
|
||
| A driver dependency is also required to connect to a specified database. Here are drivers currently supported: | ||
| Here are drivers currently supported: |
There was a problem hiding this comment.
nit: Here are drivers -> Here are the drivers
| @@ -58,7 +73,8 @@ A driver dependency is also required to connect to a specified database. Here ar | |||
| | OceanBase | `com.oceanbase` | `oceanbase-client` | [Download](https://repo1.maven.org/maven2/com/oceanbase/oceanbase-client/) | | |||
|
|
|||
|
|
|||
| JDBC connector and drivers are not part of Flink's binary distribution. See how to link with them for cluster execution [here]({{< ref "docs/dev/configuration/overview" >}}). | |||
| JDBC connector and drivers are not part of Flink's binary distribution. | |||
There was a problem hiding this comment.
nit: JDBC connector -> The JDBC connector
| @@ -58,7 +73,8 @@ A driver dependency is also required to connect to a specified database. Here ar | |||
| | OceanBase | `com.oceanbase` | `oceanbase-client` | [Download](https://repo1.maven.org/maven2/com/oceanbase/oceanbase-client/) | | |||
|
|
|||
|
|
|||
| JDBC connector and drivers are not part of Flink's binary distribution. See how to link with them for cluster execution [here]({{< ref "docs/dev/configuration/overview" >}}). | |||
| JDBC connector and drivers are not part of Flink's binary distribution. | |||
| See how to link with them for cluster execution [here]({{< ref "docs/dev/configuration/overview" >}}). | |||
There was a problem hiding this comment.
nit: what do we mean by link with. It sounds like linking after compiling. I suggest, See how to use them
| @@ -6,7 +6,7 @@ | |||
| <parent> | |||
| <groupId>org.apache.flink</groupId> | |||
| <artifactId>flink-connector-jdbc-parent</artifactId> | |||
| <version>4.0-SNAPSHOT</version> | |||
| <version>4.1-SNAPSHOT</version> | |||
There was a problem hiding this comment.
I ams curious should this be 4.0.1 ?
This PR updates version to 4.1-SNAPSHOT and updates docs.