[MINOR] Optimizing metadata getter for metadata table

[nsivabalan]

Change Logs

• Optimizing metadata getter for metadata table

Impact

• Optimizing metadata getter for metadata table. Short circuiting getMetadataWriter for metadata table.

Risk level (write none, low medium or high below)

none.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

• The config description must be updated if new configs are added or the default value of the configs are changed
• Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
  ticket number here and follow the instruction to make
  changes to the website.

Contributor's checklist

• Read through contributor's guide
• Change Logs and Impact were stated clearly
• Adequate tests were added if applicable
• CI passed

[vinothchandar]

pushed the change myself

[danny0405]

is this a over-protection code, how could a MDT invoke the getMetadataWriter method.

[nsivabalan]

@danny0405 : from a HoodieTable standpoint, so far we don't differentiate data table vs metadata table.
So, we just call getMetadataWriter() and then trigger an update.
So, when the HoodieTable is referring to a metadata table, when we do getMetadataWriter() it will return Option.empty().
I was just trying to optimize that call to return immediately.

[danny0405]

I was just trying to optimize that call to return immediately.

It is throwing instead of return early which is think is kind of over-protection, because MDT should be disabled in the MDT writer config/table config.

[vinothchandar]

is this a over-protection code, how could a MDT invoke the getMetadataWriter method.
When I threw an exception tests did fail. So legit check here. to be added.

[danny0405]

+1, returns empty seems more user friendly.

[hudi-bot]

CI report:

• d3973f7 Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build