-
Notifications
You must be signed in to change notification settings - Fork 936
Support LDAPGroupProvider #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @wheatxiong, the Apache GitHub repo requires the first contributors to run CI after approving, you can send a small PR to unlock it, e.g. #3965 |
Codecov Report
@@ Coverage Diff @@
## master #4001 +/- ##
=============================================
+ Coverage 0.00% 52.95% +52.95%
- Complexity 0 13 +13
=============================================
Files 564 548 -16
Lines 31311 29931 -1380
Branches 4098 4004 -94
=============================================
+ Hits 0 15850 +15850
+ Misses 31311 12618 -18693
- Partials 0 1463 +1463
... and 554 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
OK, i get it |
@pan3793 Please help to review this pr to prevent ugly code, thanks |
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/test/scala/org/apache/kyuubi/plugin/PluginLoaderSuite.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/session/LDAPGroupProvider.scala
Outdated
Show resolved
Hide resolved
@wheatxiong sorry for the late reply, I'm working on #4152 which mainly referring the Hive codebase. AFAIK, the Hive ecosystem w/ LDAP is mature, let's keep the same behavior(configuration name and logic) w/ Hive LDAP unless the new design has significant advantages. |
thanks, i will refer to the implementation of HIVE |
Hi @wheatxiong @pan3793 , any update for LDAP group provider feature? |
Why are the changes needed?
#3897 had exposed GroupProvider, we implement LDAPGroupProvider to special group mapping mechanisms through LDAP
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request