Expose metrics of engine startup permit state #7072
Closed
+157
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
LennonChin
force-pushed
the
engine_startup_metrics
branch
from
59246d6 to
483f44e
Compare
|
@wForget cc |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7072 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 697 697
Lines 43192 43203 +11
Branches 5854 5854
======================================
- Misses 43192 43203 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cxzl25
approved these changes
May 26, 2025
pan3793
reviewed
May 26, 2025
docs/monitor/metrics.md
Outdated
| @@ -65,6 +65,9 @@ These metrics include: | |||
| | `kyuubi.engine.timeout` | | counter | 1.2.0 | <div style='width: 150pt;word-wrap: break-word;white-space: normal'> cumulative timeout engines</div> | | |||
| | `kyuubi.engine.failed` | `${user}` | counter | 1.2.0 | <div style='width: 150pt;word-wrap: break-word;white-space: normal'> cumulative explicitly failed engine count for a `${user}`</div> | | |||
| | `kyuubi.engine.failed` | `${errorType}` | counter | 1.2.0 | <div style='width: 150pt;word-wrap: break-word;white-space: normal'> cumulative explicitly failed engine count for a particular `${errorType}`, e.g. `ClassNotFoundException`</div> | | |||
| | `kyuubi.engine.startup.permit.limit.total` | | meter | 1.10.1 | <div style='width: 150pt;word-wrap: break-word;white-space: normal'> concurrently startup engines permit limit </div> | | |||
There was a problem hiding this comment.
@pan3793 Updated doc version, added grafana pannel json and resolved conflicts, please review again.
|
It's also encouraged to update the Grafana Dashboard when adding new metrics https://github.com/apache/kyuubi/tree/master/grafana |
LennonChin
force-pushed
the
engine_startup_metrics
branch
from
483f44e to
d6bf369
Compare
turboFei
approved these changes
May 27, 2025
|
Thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The metrics
kyuubi_operation_state_LaunchEngine_*cannot reflect the state of Semaphore after configuring the maximum engine startup limit throughkyuubi.server.limit.engine.startup, add some metrics to show the relevant permit state.How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?