Skip to content

Convert some complex PriorityQueue implementations to comparators #14817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2025

Conversation

thecoop
Copy link
Contributor

@thecoop thecoop commented Jun 19, 2025

A 3rd set of PriorityQueue conversions. These ones are more controversial, and so need some specific review and discussion

Copy link

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

Copy link

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

Copy link

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@thecoop
Copy link
Contributor Author

thecoop commented Jun 19, 2025

The subclasses that are remaining after this PR are:

  • TermsMergeQueue. This has some additional state in the stack variable
  • FieldValueHitQueue. This is further subclassed, and is public (although experimental)
  • HitQueue. Public class (although internal). Used in several difference places, so this class represents some common functionality.
  • TopDocs.ScoreMergeSortQueue, TopDocs.MergeSortQueue. Has some significant state fields in them
  • TopOrdAndNumberQueue and subclasses. Part of the public API, and has some abstract behavious set by subclasses
  • SuggestWordQueue. Public API

@thecoop thecoop requested review from dweiss and dsmiley June 26, 2025 09:08
Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Please consider one rename and add a changes.txt entry - this is a significant change and cleanup, worth mentioning in the docs.

@github-actions github-actions bot added this to the 11.0.0 milestone Jun 26, 2025
@thecoop thecoop merged commit 8e2c6aa into apache:main Jun 27, 2025
8 checks passed
@thecoop thecoop deleted the priority-queue-complex-comparators branch June 27, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants