Make it possible to extend Patience/Seeded knn queries #14838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
|
nit: this also fixes a minor javadoc issue |
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
benwtrent
reviewed
Jun 23, 2025
lucene/core/src/java/org/apache/lucene/search/PatienceKnnVectorQuery.java
Outdated
Show resolved
Hide resolved
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
benwtrent
approved these changes
Jun 24, 2025
tteofili
changed the title
|
@benwtrent extended this to |
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
tteofili
added a commit
that referenced
this pull request
Jun 25, 2025
(cherry picked from commit 2b47cd3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
PatienceKnnQueryextends and is constructed by anAbstractKnnQuery, which is not public and therefore avoids other classes to extend it (as the related ctor is also package private).This simply makes
PatienceKnnQueryconstructors public and strict about the type of the wrapped query (float, byte, seeded knn queries),