ci: enable gh annotations with ast-grep #14840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error is still printed to console, but in a special structured format recognized by actions to highlight and annotate the problem in your PR. When clicking the build failure, annotations can be seen at the very top of action link (no need to look at logs). Github does highlight the failures in red in the logs as well. You can see the problems annotated inline in the sources, when reviewing the changes.
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
|
ill try to look if it makes sense to configure any other checkers... if you have ideas let me know. the EditorConfigLint would be my first idea to look at next otherwise, due to the fact it is golang tool and not "gradle native". if linters doesn't support the actions format, we can alternatively put json files in .github directory that specify vim efm-like patterns: https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md |
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error is still printed to console, but in a special structured format recognized by actions to highlight and annotate the problem in your PR.
When clicking the build failure, annotations can be seen at the very top of action link (no need to look at logs). Github does highlight the failures in red in the logs as well.
You can see the problems annotated inline in the sources, when reviewing the changes.
Relates: #14835
@dweiss, I know it doesn't solve that issue, nor does it even make use of the autofix I wrote, but I still think it is an improvement to usability.