-
Notifications
You must be signed in to change notification settings - Fork 445
nimble/apps/tester: Implement GATT Server BTP Service (ID 0x07) #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
piotrnarajowski
wants to merge
3
commits into
apache:master
Choose a base branch
from
piotrnarajowski:GATTS_BTP_SERVICE
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf0fbb7
to
f2071c3
Compare
f2071c3
to
03a7fa7
Compare
It might be good if this was parted into several commits - i.e. changes made to header files might be separated into standalone commit. |
7cf9288
to
eec2aa2
Compare
eec2aa2
to
33fd2fb
Compare
9784d2d
to
89b8488
Compare
New BTP service is introduced. Most of the changes are just migration of code from btp_gatt.c and btp_gatt.h. Changes also include refactor of notifications sent by server and database initialization: - os_callout_init and functions/variables realted to it are removed. It was responsible for starting a timer when peer has subscribed for notifications/indications and sending notifications right after the timer has expired. An updated version of gatts_set_value command can be used to set values of one or more characteristics and handles sending notifications, indications and multiple handle value notifications - All predefined ble_gatt_svc_def structs will be registred on GATTS service registration with visibility set to invisible. BTP_GATTS_INITIALIZE_DATABASE command can be used to make chosen database visible.
- Removes files and content related to BTP GATT Service (0x02). - All necessary content has been migrated to btp_gatts.c and btp_gatts.h files - Ensured no loss of functionality; all essential GATT components preserved
89b8488
to
ae31a0e
Compare
This metod allows reading configuration flags of Client Characteristic Configuration Descriptor for specified characteristic.
ae31a0e
to
645b0e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New BTP service is introduced. Most of the changes are just migration of code from btp_gatt.c and btp_gatt.h. Changes also include refactor of notifications sent by server and database initialization:
Related auto-pts/auto-pts#1367