Skip to content

nimble/bttester: Subrating support #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2025

Conversation

szymon-czapracki
Copy link
Contributor

Add support for subrating.
Introduce subrating commands and functions in btp.
Change style of btp GAP handlers due to failing style-checks.

@github-actions github-actions bot added the size/M Medium PR label Jul 7, 2025
@github-actions github-actions bot added the size/S Small PR label Jul 7, 2025
@szymon-czapracki szymon-czapracki changed the title nimble/bttester: Subrating support & style changes nimble/bttester: Subrating support Jul 7, 2025
@szymon-czapracki
Copy link
Contributor Author

@sjanc Some of the code in the handler section may fail the style-check.
If the code looks good to you, please add skip-style-check, would you kindly?

@szymon-czapracki
Copy link
Contributor Author

#AutoPTS run mynewt GAP/CSUB

@codecoup-tester
Copy link

Scheduled PR #2077 (comment), board: nrf52, estimated start time: 13:52:47, test case count: 2, estimated duration: 0:11:35

Test cases to be runGAP/CSUB/CSR/BV-01-C
GAP/CSUB/CSU/BV-01-C

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed tests (2)GAP GAP/CSUB/CSR/BV-01-C MISSING WID ERROR
GAP GAP/CSUB/CSU/BV-01-C MISSING WID ERROR

@sjanc
Copy link
Contributor

sjanc commented Jul 25, 2025

#AutoPTS run mynewt GAP/CSUB

Enable subrating features for bttester.
This feature is required for following tests:
GAP/CSUB/CSR/BV-01-C & GAP/CSUB/CSU/BV-01-C.
Add proper BTP  subrating commands and functions in GAP.
Required to satisfy corresponding auto-pts layer.
Add Subrate change event definition and handling
in BTP layer.
`ble_gap_rx_subrate_change()` handler now
invokes `ble_gap_call_conn_event_cb()` to allow applications to react
to subrate change events.

This addition ensures that registered connection event callbacks are
notified when a subrate change occurs, providing better support
for LE Subrate procedures.
@codecoup-tester
Copy link

Scheduled PR #2077 (comment), board: nrf52, estimated start time: 17:27:12, test case count: 2, estimated duration: 0:11:31

Test cases to be runGAP/CSUB/CSR/BV-01-C
GAP/CSUB/CSU/BV-01-C

@codecoup-tester
Copy link

AutoPTS Bot results:
No failed test found.

Successful tests (2)GAP GAP/CSUB/CSR/BV-01-C PASS
GAP GAP/CSUB/CSU/BV-01-C PASS

@sjanc sjanc merged commit ae62dda into apache:master Jul 25, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants